netdev - Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161127130400.4a69ff1b@canb.auug.org.au>
Date:   Sun, 27 Nov 2016 13:04:00 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Eli Cooper <elicooper@....com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] sit: Set skb->protocol properly in
 ipip6_tunnel_xmit()

Hi Eli,

[Just for Dave's information]

On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper <elicooper@....com> wrote:
>
> Similar to commit ae148b085876
> ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"),
> sit tunnels also need to update skb->protocol; otherwise, TSO/GSO packets
> might not be properly segmented, which causes the packets being dropped.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Tested-by: Eli Cooper <elicooper@....com>
> Cc: stable@...r.kernel.org
> Signed-off-by: Eli Cooper <elicooper@....com>

I tested this patch and it does *not* solve my problem.

-- 
Cheers,
Stephen Rothwell