[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20161127.203736.1937105888251361121.davem@davemloft.net>
Date: Sun, 27 Nov 2016 20:37:36 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: jon.maloy@...csson.com
Cc: netdev@...r.kernel.org, parthasarathy.bhuvaragan@...csson.com,
ying.xue@...driver.com, maloy@...jonn.com,
tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: fix link statistics counter errors
From: Jon Maloy <jon.maloy@...csson.com>
Date: Fri, 25 Nov 2016 10:35:02 -0500
> In commit e4bf4f76962b ("tipc: simplify packet sequence number
> handling") we changed the internal representation of the packet
> sequence number counters from u32 to u16, reflecting what is really
> sent over the wire.
>
> Since then some link statistics counters have been displaying incorrect
> values, partially because the counters meant to be used as sequence
> number snapshots are now used as direct counters, stored as u32, and
> partially because some counter updates are just missing in the code.
>
> In this commit we correct this in two ways. First, we base the
> displayed packet sent/received values on direct counters instead
> of as previously a calculated difference between current sequence
> number and a snapshot. Second, we add the missing updates of the
> counters.
>
> This change is compatible with the current netlink API, and requires
> no changes to the user space tools.
>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>
Applied.
Powered by blists - more mailing lists