netdev - Re: [PATCH] net/iucv: use explicit clean up labels in iucv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161128.112433.295947046706527102.davem@davemloft.net>
Date:   Mon, 28 Nov 2016 11:24:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bigeasy@...utronix.de
Cc:     ubraun@...ux.vnet.ibm.com, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, rt@...utronix.de,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net/iucv: use explicit clean up labels in iucv_init()

From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Date: Thu, 24 Nov 2016 17:10:13 +0100

> Ursula suggested to use explicit labels for clean up in the error path
> instead of one `out_free' label which handles multiple exits.
> Since the previous patch got already applied, here is a follow up patch.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

"Previous patch" doesn't tell readers anything specific enough to identify
the change you are referring to.  This will be even more true years down
the line if someone tries to read this commit and figure out what you
are referring to.

We have a standard mechanism to refer to commits, via SHA1_ID and commit
header line text, please use it.

Thank you.