netdev - Re: [PATCH 1/1] GSO: Reload iph after pskb_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UdeSd91LUYWsHnnuKgM9bTydkzQ7r3B3n-nsVnT0gmzvg@mail.gmail.com>
Date:   Mon, 28 Nov 2016 08:34:59 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Alexander Duyck <aduyck@...antis.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Linux Networking Development Mailing List 
        <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] GSO: Reload iph after pskb_may_pull

On Mon, Nov 28, 2016 at 7:36 AM, Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
> As it may get stale and lead to use after free.
>
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Alexander Duyck <aduyck@...antis.com>
> Cc: Andrey Konovalov <andreyknvl@...gle.com>
> Fixes: cbc53e08a793 ("GSO: Add GSO type for fixed IPv4 ID")
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  net/ipv4/af_inet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
> index 5ddf5cda07f4..215143246e4b 100644
> --- a/net/ipv4/af_inet.c
> +++ b/net/ipv4/af_inet.c
> @@ -1233,7 +1233,7 @@ struct sk_buff *inet_gso_segment(struct sk_buff *skb,
>                 fixedid = !!(skb_shinfo(skb)->gso_type & SKB_GSO_TCP_FIXEDID);
>
>                 /* fixed ID is invalid if DF bit is not set */
> -               if (fixedid && !(iph->frag_off & htons(IP_DF)))
> +               if (fixedid && !(ip_hdr(skb)->frag_off & htons(IP_DF)))
>                         goto out;
>         }
>
> --
> 2.9.3
>

Looks good to me.

Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>