lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Nov 2016 22:23:28 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Or Gerlitz <gerlitz.or@...il.com> Cc: Amir Vadai <amir@...ai.me>, Linux Netdev List <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, Jamal Hadi Salim <jhs@...atatu.com>, Ido Schimmel <idosch@...lanox.com>, Elad Raz <eladr@...lanox.com>, Or Gerlitz <ogerlitz@...lanox.com>, Hadar Hen Zion <hadarh@...lanox.com> Subject: Re: [patch net] sched: cls_flower: remove from hashtable only in case skip sw flag is not set Mon, Nov 28, 2016 at 10:04:56PM CET, gerlitz.or@...il.com wrote: >On Mon, Nov 28, 2016 at 4:40 PM, Jiri Pirko <jiri@...nulli.us> wrote: >> From: Jiri Pirko <jiri@...lanox.com> >> >> Be symmetric to hashtable insert and remove filter from hashtable only >> in case skip sw flag is not set. >> >> Fixes: e69985c67c33 ("net/sched: cls_flower: Introduce support in SKIP SW flag") > >Amir, Jiri - what was the impact of running without this fix for the >last 3-4 kernels? I haven't seen any crashes, is that leaking took >place? or this is just a cleanup to make things more clear and >maintainable? It's a fix for real bug. If you add rule with skip_sw flag, it is not inserted into hashtable. But once you remove it, the current code removes it from hashtable (did not inspect how rhashtable implementation handles this).
Powered by blists - more mailing lists