netdev - Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1480371962.2402.36.camel@intel.com>
Date:   Mon, 28 Nov 2016 14:26:02 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     sfr@...b.auug.org.au, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org
Cc:     Alexander Duyck <alexander.h.duyck@...el.com>, davem@...emloft.net
Subject: Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

On Mon, 2016-11-28 at 10:42 -0500, Alexander Duyck wrote:
> When I implemented the GSO partial support in the Intel drivers I was
> using
> lco_csum to compute the checksum that we needed to plug into the IPv4
> checksum field in order to cancel out the data that was not a part of the
> IPv4 header.  However this didn't take into account that the transport
> offset might be pointing to the inner transport header.
> 
> Instead of using lco_csum I have just coded around it so that we can use
> the outer IP header plus the IP header length to determine where we need
> to
> start our checksum and then just call csum_partial ourselves.
> 
> This should fix the SIT issue reported on igb interfaces as well as
> simliar
> issues that would pop up on other Intel NICs.
> 
> ---
> 
> Alexander Duyck (2):
>       igb/igbvf: Don't use lco_csum to compute IPv4 checksum
>       ixgbe/ixgbevf: Don't use lco_csum to compute IPv4 checksum

Stephen, I have applied Alex's patches to my net-queue tree.  Can you
confirm they resolve the bug seen?
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)