netdev - Re: [net,v2] neigh: fix the loop index error in neigh dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e3623c4-a55e-5809-ca9a-2dbd59cda871@cumulusnetworks.com>
Date:   Sun, 27 Nov 2016 22:07:28 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     张胜举 <zhangshengju@...s.chinamobile.com>,
        netdev@...r.kernel.org
Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump

On 11/27/16 9:50 PM, 张胜举 wrote:
> No, when dump request must be processed by multiple 'recv/recvmsg' system
> calls, 
> idx stores which dev/neigh the previous call have processed, so that next
> call will scan 
> from the right place.  

I have tested multiple calls and I do not see redundant information or missing information. 

> 
> So no matter whether the dev/neigh is filtered, the idx should be increased
> anyway.

No, it does not. Again, idx is the index in the list of devices/ of interest. It is NOT a device index nor is it the absolute index in the list. It is a relative index. The filter is the same across recvmsg calls so the idx count is absolutely fine.

Produce a test case that fails.