netdev - Re: [PATCH net] net/sched: act_pedit: limit negative offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161128.004936.2064564176474656911.davem@davemloft.net>
Date:   Mon, 28 Nov 2016 00:49:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     amir@...ai.me, netdev@...r.kernel.org, jhs@...atatu.com,
        ogerlitz@...lanox.com, hadarh@...lanox.com, jiri@...lanox.com
Subject: Re: [PATCH net] net/sched: act_pedit: limit negative offset

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sun, 27 Nov 2016 21:39:33 -0800

> On Sun, Nov 27, 2016 at 7:58 AM, Amir Vadai <amir@...ai.me> wrote:
>> Should not allow setting a negative offset that goes below the skb head.
> ...
>> diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
>> index b54d56d4959b..e79e8a88f2d2 100644
>> --- a/net/sched/act_pedit.c
>> +++ b/net/sched/act_pedit.c
>> @@ -154,8 +154,11 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
>>                         }
>>
>>                         ptr = skb_header_pointer(skb, off + offset, 4, &_data);
>> -                       if (!ptr)
>> +                       if ((unsigned char *)ptr < skb->head) {
> 
> 
> ptr returned could be &_data, which is on stack, so why this comparison
> makes sense for this case?

Indeed, this will definitely do the wrong thing when the on-stack area
passed back to ptr.