netdev - Re: [net-next] macvtap: replace printk with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68530b91-4548-f122-4b93-41ad4fc5de84@redhat.com>
Date:   Tue, 29 Nov 2016 18:04:53 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Zhang Shengju <zhangshengju@...s.chinamobile.com>,
        netdev@...r.kernel.org
Subject: Re: [net-next] macvtap: replace printk with netdev_err



On 2016年11月29日 11:26, Zhang Shengju wrote:
> This patch replaces printk() with netdev_err() for macvtap device.
>
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> ---
>   drivers/net/macvtap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> index 5da9861..2513939 100644
> --- a/drivers/net/macvtap.c
> +++ b/drivers/net/macvtap.c
> @@ -437,7 +437,7 @@ static int macvtap_get_minor(struct macvlan_dev *vlan)
>   	if (retval >= 0) {
>   		vlan->minor = retval;
>   	} else if (retval == -ENOSPC) {
> -		printk(KERN_ERR "too many macvtap devices\n");
> +		netdev_err(vlan->dev, "Too many macvtap devices\n");
>   		retval = -EINVAL;
>   	}
>   	mutex_unlock(&minor_lock);

Acked-by: Jason Wang <jasowang@...hat.com>