netdev - RE: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D4096FC85@CHN-SV-EXMX02.mchp-main.com>
Date:   Tue, 29 Nov 2016 18:49:45 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <f.fainelli@...il.com>, <davem@...emloft.net>, <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

> > +	/* LED2/PME_N/IRQ_N/RGMII_ID pin to IRQ_N mode */
> > +	buf = phy_read_mmd_indirect(phydev, 32784, 3);
> > +	buf &= ~0x1800;
> > +	buf |= 0x0800;
> > +	phy_write_mmd_indirect(phydev, 32784, 3, buf);
> 
> Using decimal numbers for register addresses is a bit unusual.

OK. Will change it.

> > +
> > +	/* RGMII MAC TXC Delay Enable */
> > +	ret = lan78xx_write_reg(dev, MAC_RGMII_ID,
> > +				MAC_RGMII_ID_TXC_DELAY_EN_);
> > +
> > +	/* RGMII TX DLL Tune Adjust */
> > +	ret = lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00);
> > +
> > +	*interface = PHY_INTERFACE_MODE_RGMII_TXID;
> > +}
> > +
> > +static void ksz9031rnx_pre_config(struct lan78xx_net *dev,
> > +				  struct phy_device *phydev,
> > +				  phy_interface_t *interface)
> > +{
> > +	/* Micrel9301RNX PHY configuration */
> > +	/* RGMII Control Signal Pad Skew */
> > +	phy_write_mmd_indirect(phydev, 4, 2, 0x0077);
> > +	/* RGMII RX Data Pad Skew */
> > +	phy_write_mmd_indirect(phydev, 5, 2, 0x7777);
> > +	/* RGMII RX Clock Pad Skew */
> > +	phy_write_mmd_indirect(phydev, 8, 2, 0x1FF);
> > +
> > +	*interface = PHY_INTERFACE_MODE_RGMII_RXID;
> > +}
> 
> This should really belong in the respective PHY drivers for these PHYs,
> is there a particular reason you decided to do this here?

Main reason is because these are MAC dependent.
In case these are in PHY driver, I expect some parameters/defines may need to be passed to it.
Trying to keep PHY driver as generic as possible.

Thanks for your comments.
- Woojung