netdev - Re: [PATCH net-next] bpf: add test for the verifier equal logic bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161129185359.GC22581@ast-mbp.thefacebook.com>
Date:   Tue, 29 Nov 2016 10:54:07 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Josef Bacik <jbacik@...com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, ast@...nel.org,
        jannh@...gle.com, daniel@...earbox.net, kernel-team@...com
Subject: Re: [PATCH net-next] bpf: add test for the verifier equal logic bug

On Tue, Nov 29, 2016 at 12:35:19PM -0500, Josef Bacik wrote:
> This is a test to verify that
> 
> bpf: fix states equal logic for varlen access
> 
> actually fixed the problem.  The problem was if the register we added to our map
> register was UNKNOWN in both the false and true branches and the only thing that
> changed was the range then we'd incorrectly assume that the true branch was
> valid, which it really wasnt.  This tests this case and properly fails without
> my fix in place and passes with it in place.
> 
> Signed-off-by: Josef Bacik <jbacik@...com>

Awesome. thanks for the test!
Acked-by: Alexei Starovoitov <ast@...nel.org>