netdev - Re: [net-next v2] neigh: remove duplicate check for same neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161130.134636.1025832193501844293.davem@davemloft.net>
Date:   Wed, 30 Nov 2016 13:46:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     zhangshengju@...s.chinamobile.com
Cc:     netdev@...r.kernel.org, dsa@...ulusnetworks.com
Subject: Re: [net-next v2] neigh: remove duplicate check for same neigh

From: Zhang Shengju <zhangshengju@...s.chinamobile.com>
Date: Wed, 30 Nov 2016 11:24:42 +0800

> Currently loop index 'idx' is used as the index in the neigh list of interest.
> It's increased only when the neigh is dumped. It's not the absolute index in
> the list. Because there is no info to record which neigh has already be scanned
> by previous loop. This will cause the filtered out neighs to be scanned mulitple
> times.
> 
> This patch make idx as the absolute index in the list, it will increase no matter
> whether the neigh is filtered. This will prevent the above problem.
> 
> And this is in line with other dump functions.
> 
> v2:
>  - take David Ahern's advice to do simple change
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>

Applied, thanks.