netdev - Re: [PATCH v2 net 0/5] l2tp: fixes for l2tp_ip and l2tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161130.141431.499272222182312623.davem@davemloft.net>
Date:   Wed, 30 Nov 2016 14:14:31 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jchapman@...alix.com
Cc:     g.nault@...halink.fr, netdev@...r.kernel.org, celston@...alix.com
Subject: Re: [PATCH v2 net 0/5] l2tp: fixes for l2tp_ip and l2tp_ip6 socket
 handling

From: James Chapman <jchapman@...alix.com>
Date: Tue, 29 Nov 2016 13:47:06 +0000

> On 29/11/16 12:09, Guillaume Nault wrote:
>> This series addresses problems found while working on commit 32c231164b76
>> ("l2tp: fix racy SOCK_ZAPPED flag check in l2tp_ip{,6}_bind()").
>>
>> The first three patches fix races in socket's connect, recv and bind
>> operations. The last two ones fix scenarios where l2tp fails to
>> correctly lookup its userspace sockets.
>>
>> Apart from the last patch, which is l2tp_ip6 specific, every patch
>> fixes the same problem in the L2TP IPv4 and IPv6 code.
>>
>> All problems fixed by this series exist since the creation of the
>> l2tp_ip and l2tp_ip6 modules.
>>
>> Changes since v1:
>>   * Patch #3: fix possible uninitialised use of 'ret' in l2tp_ip_bind().
 ...
> Looks good.
> 
> Acked-by: James Chapman <jchapman@...alix.com>

Series applied.