netdev - Re: [PATCH 18/39] Annotate hardware config module parameters in drivers/net/can/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8f03afb-05b4-c710-c948-948cefc12c80@pengutronix.de>
Date:   Thu, 1 Dec 2016 14:05:14 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org
Cc:     gnomes@...rguk.ukuu.org.uk, minyard@....org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        Wolfgang Grandegger <wg@...ndegger.com>
Subject: Re: [PATCH 18/39] Annotate hardware config module parameters in
 drivers/net/can/

On 12/01/2016 01:32 PM, David Howells wrote:
> When the kernel is running in secure boot mode, we lock down the kernel to
> prevent userspace from modifying the running kernel image.  Whilst this
> includes prohibiting access to things like /dev/mem, it must also prevent
> access by means of configuring driver modules in such a way as to cause a
> device to access or modify the kernel image.
> 
> To this end, annotate module_param* statements that refer to hardware
> configuration and indicate for future reference what type of parameter they
> specify.  The parameter parser in the core sees this information and can
> skip such parameters with an error message if the kernel is locked down.
> The module initialisation then runs as normal, but just sees whatever the
> default values for those parameters is.
> 
> Note that we do still need to do the module initialisation because some
> drivers have viable defaults set in case parameters aren't specified and
> some drivers support automatic configuration (e.g. PNP or PCI) in addition
> to manually coded parameters.
> 
> This patch annotates drivers in drivers/net/can/.
> 
> Suggested-by: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Wolfgang Grandegger <wg@...ndegger.com>
> cc: Marc Kleine-Budde <mkl@...gutronix.de>
> cc: linux-can@...r.kernel.org
> cc: netdev@...r.kernel.org

Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)