netdev - RE: [PATCH] sh_eth: add missing checks for status bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SG2PR06MB1165EF1344470A957BB9C34A8A8F0@SG2PR06MB1165.apcprd06.prod.outlook.com>
Date:   Thu, 1 Dec 2016 13:13:05 +0000
From:   Chris Brandt <Chris.Brandt@...esas.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        David Miller <davem@...emloft.net>
CC:     Simon Horman <horms+renesas@...ge.net.au>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH] sh_eth: add missing checks for status bits

On 12/1/2016, Sergei Shtylyov wrote:

> Hello!
> 
>     Please always CC me on the sh_eth/ravb driver patches as directed by
> scripts/get_maintainer.pl.

OK. I'm sorry.


> On 11/30/2016 11:01 PM, Chris Brandt wrote:
> 
> > When streaming a lot of data and the RZ can't keep up, some status
> > bits will get set that are not being checked or cleared which cause
> > the following messages and the Ethernet driver to stop working. This
> > patch fixes that issue.
> 
>     Perhaps we should just clear the correspoding bits in EESIPR instead?
> They are not set for any other SoC...


That's a good point. If we don't plan on doing anything with those bits, they should not be causing interrupts.

I will try change and then re-test.


Chris