netdev - Re: [PATCH net] net: bcmgenet: Utilize correct struct device for all DMA operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99ae5d99-23cb-7e48-6366-d0206b7f92cc@gmail.com>
Date:   Thu, 1 Dec 2016 09:26:04 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, pgynther@...gle.com, jaedon.shin@...il.com,
        opendmb@...il.com
Subject: Re: [PATCH net] net: bcmgenet: Utilize correct struct device for all
 DMA operations

On 11/30/2016 09:15 PM, Florian Fainelli wrote:
> __bcmgenet_tx_reclaim() is not using the struct device reference when
> doing its unmap operation, which made the DMA-API debugging warn about
> it. Fix this by always using &priv->pdev->dev throughout the driver,
> using an identical device reference for all map/unmap calls.
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

There is another wrong struct device used by bcmgenet_free_rx_buffers
that I missed here (thanks Doug), let's fix it.
-- 
Florian