netdev - Re: [PATCH v2] sh_eth: remove unchecked interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25b92de0-806b-342b-7556-06b96b948b2c@cogentembedded.com>
Date:   Thu, 1 Dec 2016 20:37:51 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Chris Brandt <chris.brandt@...esas.com>
Cc:     David Miller <davem@...emloft.net>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v2] sh_eth: remove unchecked interrupts

On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote:

>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = {
>>
>>         .ecsr_value     = ECSR_ICD,
>>         .ecsipr_value   = ECSIPR_ICDIP,
>> -       .eesipr_value   = 0xff7f009f,
>> +       .eesipr_value   = 0xe77f009f,
>
> Comment not directly related to the merits of this patch: the EESIPR bit
> definitions seem to be identical to those for EESR, so we can get rid of the
> hardcoded values here?

    Do you mean using the @define's? We have EESIPR bits also declared, see 
enum DMAC_IM_BIT,

[...]

MBR, Sergei