netdev - Re: [PATCH iproute2 2/3] ifstat: Add extended statistics to ifstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161201104611.1e3a5b05@xeon-e3>
Date:   Thu, 1 Dec 2016 10:46:11 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nogah Frankel <nogahf@...lanox.com>
Cc:     netdev@...r.kernel.org, eladr@...lanox.com, yotamg@...lanox.com,
        jiri@...lanox.com, idosch@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [PATCH iproute2 2/3] ifstat: Add extended statistics to ifstat

On Thu, 24 Nov 2016 16:12:39 +0200
Nogah Frankel <nogahf@...lanox.com> wrote:

> Add extended stats option for ifstat. It supports stats that are in the
> nesting level as the "normal" stats or one lower, as long as they are in
> the same struct type as the "normal" stats.
> Every extension is unaware of data from other extension and is being
> presented by itself.
> The extension can be called by its name or any shorten of it. If there is
> more then one matched, the first one will be picked.
> 
> To get the extended stats the flag -x <stats type> is used.
> 
> Signed-off-by: Nogah Frankel <nogahf@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Finally clearing up iproute2 patch backlog. This feature looks good,
but does not apply cleanly to current git master branch.

--- misc/ifstat.c
+++ misc/ifstat.c
@@ -733,7 +790,8 @@ static void usage(void)
 "   -s, --noupdate	don\'t update history\n"
 "   -t, --interval=SECS	report average over the last SECS\n"
 "   -V, --version	output version information\n"
-"   -z, --zeros		show entries with zero activity\n");
+"   -z, --zeros		show entries with zero activity\n"
+"   -x, --extended=TYPE	show extended stats of TYPE\n");
 
 	exit(-1);
 }

Please rebase your patches and resubmit.