netdev - Re: [PATCH] sh_eth: add missing checks for status bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <185d6cf0-6f46-9e04-a55d-5f13535c513b@cogentembedded.com>
Date:   Thu, 1 Dec 2016 13:12:39 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Simon Horman <horms@...ge.net.au>,
        Chris Brandt <chris.brandt@...esas.com>
Cc:     David Miller <davem@...emloft.net>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] sh_eth: add missing checks for status bits

Hello!

On 12/1/2016 11:52 AM, Simon Horman wrote:

>> When streaming a lot of data and the RZ can't keep up, some status bits
>> will get set that are not being checked or cleared which cause the
>> following messages and the Ethernet driver to stop working. This
>> patch fixes that issue.
>>
>> irq 21: nobody cared (try booting with the "irqpoll" option)
>> handlers:
>> [<c036b71c>] sh_eth_interrupt
>> Disabling IRQ #21
>>
>> Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100")
>> Signed-off-by: Chris Brandt <chris.brandt@...esas.com>
>
> Hi Chris,
>
> I am wondering if the EESR_FRC but should also be checked.

    EESR.FRC is not an error bit and it's part of EESR_RX_CHECK already.

MBR, Sergei