netdev - Re: [PATCH net v3] tipc: check minimum bearer MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba271624-f7aa-165e-950e-cf56b4c7621e@windriver.com>
Date:   Fri, 2 Dec 2016 20:07:15 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        Jon Maloy <jon.maloy@...csson.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        <tipc-discussion@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Ben Hutchings <ben@...adent.org.uk>,
        Qian Zhang <zhangqian-c@....cn>
Subject: Re: [PATCH net v3] tipc: check minimum bearer MTU

On 12/02/2016 04:33 PM, Michal Kubecek wrote:
> Qian Zhang (张谦) reported a potential socket buffer overflow in
> tipc_msg_build() which is also known as CVE-2016-8632: due to
> insufficient checks, a buffer overflow can occur if MTU is too short for
> even tipc headers. As anyone can set device MTU in a user/net namespace,
> this issue can be abused by a regular user.
>
> As agreed in the discussion on Ben Hutchings' original patch, we should
> check the MTU at the moment a bearer is attached rather than for each
> processed packet. We also need to repeat the check when bearer MTU is
> adjusted to new device MTU. UDP case also needs a check to avoid
> overflow when calculating bearer MTU.
>
> Fixes: b97bf3fd8f6a ("[TIPC] Initial merge")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> Reported-by: Qian Zhang (张谦) <zhangqian-c@....cn>
> ---

Thanks, it looks nice to me.

Acked-by: Ying Xue <ying.xue@...driver.com>