netdev - Re: [PATCH net-next] net/mlx5e: skip loopback selftest with !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161202.115619.1098706795726222374.davem@davemloft.net>
Date:   Fri, 02 Dec 2016 11:56:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     saeedm@...lanox.com, matanb@...lanox.com, leonro@...lanox.com,
        kamalh@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: skip loopback selftest with
 !CONFIG_INET

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 30 Nov 2016 22:05:39 +0100

> When CONFIG_INET is disabled, the new selftest results in a link
> error:
> 
> drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.o: In function `mlx5e_test_loopback':
> en_selftest.c:(.text.mlx5e_test_loopback+0x2ec): undefined reference to `ip_send_check'
> en_selftest.c:(.text.mlx5e_test_loopback+0x34c): undefined reference to `udp4_hwcsum'
> 
> This hides the specific test in that configuration.
> 
> Fixes: 0952da791c97 ("net/mlx5e: Add support for loopback selftest")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.