netdev - Re: [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue lock in tx completion handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161202.121154.2111120437823188386.davem@davemloft.net>
Date:   Fri, 02 Dec 2016 12:11:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     LinoSanfilippo@....de
Cc:     vbridger@...nsource.altera.com, nios2-dev@...ts.rocketboards.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue
 lock in tx completion handler

From: Lino Sanfilippo <LinoSanfilippo@....de>
Date: Wed, 30 Nov 2016 23:48:32 +0100

> The driver already uses its private lock for synchronization between xmit
> and xmit completion handler making the additional use of the xmit_lock
> unnecessary.
> Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be
> called with the xmit_lock held and then taking the private lock while xmit
> completion handler does the reverse, first take the private lock, then the
> xmit_lock.
> Fix these issues by not taking the xmit_lock in the tx completion handler.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>

Yeah that could be a nasty deadlock, in fact.

Applied, thanks.