netdev - Re: [PATCH net v2] net: bcmgenet: Utilize correct struct device for all DMA operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161202.135401.1662791877536448974.davem@davemloft.net>
Date:   Fri, 02 Dec 2016 13:54:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, pgynther@...gle.com, jaedon.shin@...il.com,
        opendmb@...il.com
Subject: Re: [PATCH net v2] net: bcmgenet: Utilize correct struct device
 for all DMA operations

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu,  1 Dec 2016 09:45:45 -0800

> From: Florian Fainelli <f.fainelli@...il.com>
> 
> __bcmgenet_tx_reclaim() and bcmgenet_free_rx_buffers() are not using the
> same struct device during unmap that was used for the map operation,
> which makes DMA-API debugging warn about it. Fix this by always using
> &priv->pdev->dev throughout the driver, using an identical device
> reference for all map/unmap calls.
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks.