netdev - Re: [PATCH net] net: avoid signed overflows for SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161202.141041.912805364993627369.davem@davemloft.net>
Date:   Fri, 02 Dec 2016 14:10:41 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, andreyknvl@...gle.com
Subject: Re: [PATCH net] net: avoid signed overflows for
 SO_{SND|RCV}BUFFORCE

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 02 Dec 2016 09:44:53 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> CAP_NET_ADMIN users should not be allowed to set negative
> sk_sndbuf or sk_rcvbuf values, as it can lead to various memory
> corruptions, crashes, OOM...
> 
> Note that before commit 82981930125a ("net: cleanups in
> sock_setsockopt()"), the bug was even more serious, since SO_SNDBUF
> and SO_RCVBUF were vulnerable.
> 
> This needs to be backported to all known linux kernels.
> 
> Again, many thanks to syzkaller team for discovering this gem.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>

Applied and queued up for -stable, thanks Eric.