netdev - Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff997367-17cd-d484-17b4-6a09b1f9e74f@arista.com>
Date:   Thu, 1 Dec 2016 21:41:30 -0800
From:   Erik Nordmark <nordmark@...sta.com>
To:     Hannes Frederic Sowa <hannes@...essinduktion.org>,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, Bob Gilligan <gilligan@...sta.com>
Subject: Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD
 (RFC7527)

On 12/1/16 2:28 PM, Hannes Frederic Sowa wrote:
> Reviewed-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Thanks - I'll add that.
Also got a warning from the kbuild test robot for route.c which I'll fix.

>
> Thanks!
>> @@ -794,6 +808,17 @@ static void ndisc_recv_ns(struct sk_buff *skb)
>>   have_ifp:
>>   		if (ifp->flags & (IFA_F_TENTATIVE|IFA_F_OPTIMISTIC)) {
>>   			if (dad) {
>> +				if (nonce != 0 && ifp->dad_nonce == nonce) {
>> +					u8 *np = (u8 *)&nonce;
>> +					/* Matching nonce if looped back */
>> +					ND_PRINTK(2, notice,
>> +						  "%s: IPv6 DAD loopback for address %pI6c nonce %02x:%02x:%02x:%02x:%02x:%02x ignored\n",
>> +						  ifp->idev->dev->name,
>> +						  &ifp->addr,
>> +						  np[0], np[1], np[2], np[3],
>> +						  np[4], np[5]);
>> +					goto out;
>> +				}
>>   				/*
>>   				 * We are colliding with another node
>>   				 * who is doing DAD
>>
> I think it could be a "%pM" because it looks like a MAC address, but
> better leave it like that. :)

It is 6 bytes, but it isn't a mac address so I'll leave it.

Thanks,
   Erik