netdev - Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83a25cf8-907b-074e-754c-faa9e641c896@st.com>
Date:   Fri, 2 Dec 2016 09:44:48 +0100
From:   Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>,
        <alexandre.torgue@...com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

Hello Corentin

patches look ok, I just wonder if you tested it in case of
the stmmac is connected to a transceiver. Let me consider it
a critical part of the driver to properly work.

Regards
Peppe

On 12/1/2016 4:19 PM, Corentin Labbe wrote:
> This patch simply rename regValue to value, like it was named in other
> mdio functions.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index e3216e5..6796c28 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -83,14 +83,14 @@ static int stmmac_mdio_read(struct mii_bus *bus, int phyaddr, int phyreg)
>  	unsigned int mii_data = priv->hw->mii.data;
>
>  	int data;
> -	u16 regValue = (((phyaddr << 11) & (0x0000F800)) |
> +	u16 value = (((phyaddr << 11) & (0x0000F800)) |
>  			((phyreg << 6) & (0x000007C0)));
> -	regValue |= MII_BUSY | ((priv->clk_csr & 0xF) << 2);
> +	value |= MII_BUSY | ((priv->clk_csr & 0xF) << 2);
>
>  	if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address))
>  		return -EBUSY;
>
> -	writel(regValue, priv->ioaddr + mii_address);
> +	writel(value, priv->ioaddr + mii_address);
>
>  	if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address))
>  		return -EBUSY;
>