netdev - Re: [PATCH -next] net: ethernet: ti: davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161203.152757.961499505116275188.davem@davemloft.net>
Date:   Sat, 03 Dec 2016 15:27:57 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     paul.gortmaker@...driver.com
Cc:     ivan.khoronzhuk@...aro.org, mugunthanvnm@...com,
        grygorii.strashko@...com, linux-omap@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: ethernet: ti: davinci_cpdma: add missing
 EXPORTs

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Thu, 1 Dec 2016 15:25:28 -0500

> As of commit 8f32b90981dcdb355516fb95953133f8d4e6b11d
> ("net: ethernet: ti: davinci_cpdma: add set rate for a channel") the
> ARM allmodconfig builds would fail modpost with:
> 
> ERROR: "cpdma_chan_set_weight" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined!
> ERROR: "cpdma_chan_get_rate" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined!
> ERROR: "cpdma_chan_get_min_rate" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined!
> ERROR: "cpdma_chan_set_rate" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined!
> 
> Since these weren't declared as static, it is assumed they were
> meant to be shared outside the file, and that modular build testing
> was simply overlooked.
> 
> Fixes: 8f32b90981dc ("net: ethernet: ti: davinci_cpdma: add set rate for a channel")
> Cc: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
> Cc: Mugunthan V N <mugunthanvnm@...com>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: linux-omap@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied.