netdev - Re: [PATCH iproute2/net-next] ss: initialise variables outside of for loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161203083712.GA10228@penelope.horms.nl>
Date:   Sat, 3 Dec 2016 09:37:14 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2/net-next] ss: initialise variables outside of
 for loop

On Fri, Dec 02, 2016 at 02:18:17PM -0800, Stephen Hemminger wrote:
> On Fri,  2 Dec 2016 12:56:05 +0100
> Simon Horman <simon.horman@...ronome.com> wrote:
> 
> > Initialise for loops outside of for loops. GCC flags this as being
> > out of spec unless C99 or C11 mode is used.
> > 
> > With this change the entire tree appears to compile cleanly with -Wall.
> > 
> > $ gcc --version
> > gcc (Debian 4.9.2-10) 4.9.2
> > ...
> > $ make
> > ...
> > ss.c: In function ‘unix_show_sock’:
> > ss.c:3128:4: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
> > ...
> > 
> > Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> 
> Applied.

Thanks.

> Note, I used to have -Wall in Makefile but old GCC were broken and would give
> aliasing warnings.

Thanks, good to know.