netdev - Re: [PATCH 1/1] net: dcb: set error code on failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161203.235503.558375941675604872.davem@davemloft.net>
Date:   Sat, 03 Dec 2016 23:55:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bianpan201602@....com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bianpan2016@....com
Subject: Re: [PATCH 1/1] net: dcb: set error code on failures

From: Pan Bian <bianpan201602@....com>
Date: Sat,  3 Dec 2016 21:49:08 +0800

> From: Pan Bian <bianpan2016@....com>
> 
> In function dcbnl_cee_fill(), returns the value of variable err on
> errors. However, on some error paths (e.g. nla put fails), its value may
> be 0. It may be better to explicitly set a negative errno to variable
> err before returning.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188881
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied, thanks.