netdev - RE: [PATCH 1/1] net: ethernet: qlogic: set error code on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Dec 2016 07:29:58 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Pan Bian <bianpan201603@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "Elior, Ariel" <Ariel.Elior@...ium.com>
Subject: RE: [PATCH 1/1] net: ethernet: qlogic: set error code on failure

> From: Pan Bian <bianpan2016@....com>
> 
> When calling dma_mapping_error(), the value of return variable rc is 0.
> And when the call returns an unexpected value, rc is not set to a negative
> errno. Thus, it will return 0 on the error path, and its callers cannot detect
> the bug. This patch fixes the bug, assigning "-ENOMEM" to err.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189041
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

The title should have been "[PATCH net 1/1] qed: Set error code on failure".

But the fix itself is sound. Thanks.
BTW, is -ENOMEM the right return code in case of DMA mapping errors?

Acked-by: Yuval Mintz <Yuval.Mintz@...ium.com>