netdev - Re: [PATCH 1/1] isdn: hisax: set error code on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f40332a1-8fc1-96e1-5592-95e8509c68a3@cogentembedded.com>
Date:   Sun, 4 Dec 2016 13:14:18 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Pan Bian <bianpan201603@....com>,
        Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Pan Bian <bianpan2016@....com>
Subject: Re: [PATCH 1/1] isdn: hisax: set error code on failure

Hello.

On 12/4/2016 8:15 AM, Pan Bian wrote:

> From: Pan Bian <bianpan2016@....com>
>
> In function hfc4s8s_probe(), the value of return variable err should be
> negative on failures. However, when the call to request_region() returns
> NULL, the value of err is 0. This patch fixes the bug, assiging
> "-ENOMEM" to err on the path that request_region() fails.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931
>
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/isdn/hisax/hfc4s8s_l1.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
> index 9600cd7..3172cee 100644
> --- a/drivers/isdn/hisax/hfc4s8s_l1.c
> +++ b/drivers/isdn/hisax/hfc4s8s_l1.c
> @@ -1499,6 +1499,7 @@ struct hfc4s8s_l1 {
>  		printk(KERN_INFO
>  		       "HFC-4S/8S: failed to request address space at 0x%04x\n",
>  		       hw->iobase);
> +		err = -ENOMEM;

    -EBUSY fits request_region() better.

[..]

MBR, Sergei