netdev - RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR0701MB1933E2914735C68829CFB13B88800@SN1PR0701MB1933.namprd07.prod.outlook.com>
Date:   Sun, 4 Dec 2016 07:59:10 +0000
From:   "Kalderon, Michal" <Michal.Kalderon@...ium.com>
To:     Pan Bian <bianpan201604@....com>,
        "Mintz, Yuval" <Yuval.Mintz@...ium.com>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Pan Bian <bianpan2016@....com>
Subject: RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

> From: Pan Bian <bianpan2016@....com>
> 
> Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate
> memory, and jumps to label "lbl" if the allocation fails. Label "lbl"
> first cleans memory and then returns variable rc. Before calling the macro, the
> value of variable rc is 0. Because 0 means no error, the callers of
> bnx2x_init_firmware() may be misled. This patch fixes the bug, assigning "-
> ENOMEM" to rc before calling macro NX2X_ALLOC_AND_SET().
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189141
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

The title is wrong from net-next; It should have been "bnx2x: Fix improper return value".

Acked-by: Michal Kalderon <michal.kalderon@...ium.com>