netdev - Re: [PATCH 1/1] net: caif: remove ineffective check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161205.144912.1032798616829972627.davem@davemloft.net>
Date:   Mon, 05 Dec 2016 14:49:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bianpan2016@....com
Cc:     dmitry.tarnyagin@...kless.no, sergei.shtylyov@...entembedded.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] net: caif: remove ineffective check

From: Pan Bian <bianpan2016@....com>
Date: Sun,  4 Dec 2016 12:15:44 +0800

> The check of the return value of sock_register() is ineffective.
> "if(!err)" seems to be a typo. It is better to propagate the error code
> to the callers of caif_sktinit_module(). This patch removes the check
> statment and directly returns the result of sock_register().
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied.