netdev - Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161205042028.GF4310@u54ee753d2d1854bda401.ant.amazon.com>
Date:   Sun, 4 Dec 2016 20:20:28 -0800
From:   Matt Wilson <msw@...n.com>
To:     Netanel Belgazal <netanel@...apurnalabs.com>
CC:     <linux-kernel@...r.kernel.org>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <dwmw@...zon.com>,
        <zorik@...apurnalabs.com>, <alex@...apurnalabs.com>,
        <saeed@...apurnalabs.com>, <msw@...zon.com>, <aliguori@...zon.com>,
        <nafea@...apurnalabs.com>
Subject: Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote:
> ENA default hash configure IPv4_frag hash twice instead of

configure -> configures. You may want to include "erroneously". What
is the consequence of this bug?

> configure non ip packets.

configuring non-IP packets.

--msw

> Signed-off-by: Netanel Belgazal <netanel@...apurnalabs.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_com.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
> index 3066d9c..46aad3a 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_com.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
> @@ -2184,7 +2184,7 @@ int ena_com_set_default_hash_ctrl(struct ena_com_dev *ena_dev)
>  	hash_ctrl->selected_fields[ENA_ADMIN_RSS_IP4_FRAG].fields =
>  		ENA_ADMIN_RSS_L3_SA | ENA_ADMIN_RSS_L3_DA;
>  
> -	hash_ctrl->selected_fields[ENA_ADMIN_RSS_IP4_FRAG].fields =
> +	hash_ctrl->selected_fields[ENA_ADMIN_RSS_NOT_IP].fields =
>  		ENA_ADMIN_RSS_L2_DA | ENA_ADMIN_RSS_L2_SA;
>  
>  	for (i = 0; i < ENA_ADMIN_RSS_PROTO_NUM; i++) {