netdev - Re: [PATCH] virtio-net: Fix DMA-from-the-stack in virtnet_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161206.113901.1729006808840379027.davem@davemloft.net>
Date:   Tue, 06 Dec 2016 11:39:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     luto@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, mst@...hat.com,
        jasowang@...hat.com, labbott@...hat.com
Subject: Re: [PATCH] virtio-net: Fix DMA-from-the-stack in
 virtnet_set_mac_address()

From: Andy Lutomirski <luto@...nel.org>
Date: Mon,  5 Dec 2016 18:10:58 -0800

> With CONFIG_VMAP_STACK=y, virtnet_set_mac_address() can be passed a
> pointer to the stack and it will OOPS.  Copy the address to the heap
> to prevent the crash.
> 
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Laura Abbott <labbott@...hat.com>
> Reported-by: zbyszek@...waw.pl
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

Applied, thanks.