netdev - Re: [PATCH net-next 1/3] net/flow_dissector: Enable matching on flags for TC filter consumers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3xEMgkfZ2Fzt7TgtP0BFp7HQ12nf6Yx-Xek332vqBNeN=-OQ@mail.gmail.com>
Date:   Tue, 6 Dec 2016 22:51:09 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Or Gerlitz <ogerlitz@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>, Roi Dayan <roid@...lanox.com>,
        Hadar Har-Zion <hadarh@...lanox.com>,
        Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net-next 1/3] net/flow_dissector: Enable matching on flags
 for TC filter consumers

On Tue, Dec 6, 2016 at 2:43 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> Tue, Dec 06, 2016 at 01:32:57PM CET, ogerlitz@...lanox.com wrote:

>> struct flow_keys {
>>+#define FLOW_KEYS_HASH_START_FIELD control
>>       struct flow_dissector_key_control control;
>>-#define FLOW_KEYS_HASH_START_FIELD basic

> How is this hashing related to cls_flower dissections? What am I
> missing?

Oops, this is my bad. I convinced myself that flower dissections will
not work for any field which is not accounted for hash start field, I
was wrong, dropping this patch.