netdev - Re: [PATCH net-next v3 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161207.132227.1409237486028723978.davem@davemloft.net>
Date:   Wed, 07 Dec 2016 13:22:27 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     fgao@...ai8.com
Cc:     maheshb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org,
        gfree.wind@...il.com
Subject: Re: [PATCH net-next v3 1/1] driver: ipvlan: Free ipvl_port
 directly with kfree instead of kfree_rcu

From: fgao@...ai8.com
Date: Wed,  7 Dec 2016 08:44:47 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> There are two functions which would free the ipvl_port now. The first
> is ipvlan_port_create. It frees the ipvl_port in the error handler,
> so it could kfree it directly. The second is ipvlan_port_destroy. It
> invokes netdev_rx_handler_unregister which enforces one grace period
> by synchronize_net firstly, so it also could kfree the ipvl_port
> directly and safely.
> 
> So it is unnecessary to use kfree_rcu to free ipvl_port.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

Applied.