netdev - Re: Misalignment, MIPS, and ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161207.135127.789629809982860453.davem@davemloft.net>
Date:   Wed, 07 Dec 2016 13:51:27 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dave.taht@...il.com
Cc:     Jason@...c4.com, netdev@...r.kernel.org, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, wireguard@...ts.zx2c4.com
Subject: Re: Misalignment, MIPS, and ip_hdr(skb)->version

From: Dave Taht <dave.taht@...il.com>
Date: Wed, 7 Dec 2016 10:47:16 -0800

> https://git.lede-project.org/?p=openwrt/source.git;a=blob;f=target/linux/ar71xx/patches-4.4/910-unaligned_access_hacks.patch;h=b4b749e4b9c02a74a9f712a2740d63e554de5c64;hb=ee53a240ac902dc83209008a2671e7fdcf55957a

It's so much better to analyze properly where the misalignment comes from
and address it at the source, as we have for various cases that trip up
Sparc too.

Marking structures "packed" is going to kill performance and is not
the answer.