netdev - Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKh23F=PWFz9v8XgEXyjSZpUjUxn=W3UUMBokqiL-74eZTeuow@mail.gmail.com>
Date:   Wed, 7 Dec 2016 12:46:51 -0800
From:   Iyappan Subramanian <isubramanian@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Keyur Chudgar <kchudgar@....com>, netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> We never set "slots" in this function.
>
> Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> I copied how slots gets set in xgene_enet_rx_frame().  Static analysis.
> Not tested.
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 6c7eea8b36af..884a334e82d0 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
>                 return;
>
>         dev = ndev_to_dev(buf_pool->ndev);
> +       slots = buf_pool->slots - 1;
>         head = buf_pool->head;
>
>         for (i = 0; i < 4; i++) {

Thanks.

Acked-by: Iyappan Subramanian <isubramanian@....com>