netdev - Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22cd572b-b241-3d5e-0cfe-c4a2c7d0ebd0@cogentembedded.com>
Date:   Thu, 8 Dec 2016 19:29:17 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Simon Horman <horms+renesas@...ge.net.au>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

On 12/08/2016 03:28 PM, Sergei Shtylyov wrote:

>    Good to see that somebody cares still about this driver, one more task off
> my back. :-)
>
> On 12/07/2016 07:28 PM, Niklas Söderlund wrote:
>
>   You only enable the WOL support fo the R-Car gen2 chips but never say that
> explicitly, neither in the subject nor here.

    Some patch description wouldn't hurt here, especially with the way you 
implemented this support, e.g. RPM vs clk API -- that needs some explanation...

>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
>> ---
>>  drivers/net/ethernet/renesas/sh_eth.c | 120 +++++++++++++++++++++++++++++++---
>>  drivers/net/ethernet/renesas/sh_eth.h |   4 ++
>>  2 files changed, 116 insertions(+), 8 deletions(-)

>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index 05b0dc5..3974046 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.h
>> b/drivers/net/ethernet/renesas/sh_eth.h
>> index d050f37..26c6620 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.h
>> +++ b/drivers/net/ethernet/renesas/sh_eth.h
>> @@ -493,6 +493,7 @@ struct sh_eth_cpu_data {
>>      unsigned shift_rd0:1;    /* shift Rx descriptor word 0 right by 16 */
>>      unsigned rmiimode:1;    /* EtherC has RMIIMODE register */
>>      unsigned rtrate:1;    /* EtherC has RTRATE register */
>> +    unsigned magic:1;    /* EtherC have PMDE in ECMR and MPDIP in ECSIPR */
>
>    OK, e.g. RZ/A1 doesn't have these bits...

    However, I'd prefer that the comment be reworded as such:

/* EtherC has ECMR.PMDE and ECSR.MPD */

or

/* EtherC has ECMR_PMDE and ECSR_MPD */

MBR, Sergei