netdev - Re: [PATCH] net: axienet: Utilize of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161208.113421.1653870087082595146.davem@davemloft.net>
Date:   Thu, 08 Dec 2016 11:34:21 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     netdev@...r.kernel.org, michal.simek@...inx.com,
        soren.brinkmann@...inx.com, f.fainelli@...il.com
Subject: Re: [PATCH] net: axienet: Utilize of_get_mac_address()

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Wed,  7 Dec 2016 13:25:28 +0100

> Do not open code getting the MAC address exclusively from the
> "local-mac-address" property, but instead use of_get_mac_address()
> which looks up the MAC address using the 3 typical property names.
> 
> Also avoid casting away the const qualifier of the return value by
> making axienet_set_mac_address() take a const void* address.
> 
> Follows commit b34296a9c047 ("net: ethoc: Utilize
> of_get_mac_address()").
> 
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied.