lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Dec 2016 13:25:40 -0800 From: John Fastabend <john.fastabend@...il.com> To: "Michael S. Tsirkin" <mst@...hat.com> Cc: daniel@...earbox.net, shm@...ulusnetworks.com, davem@...emloft.net, tgraf@...g.ch, alexei.starovoitov@...il.com, john.r.fastabend@...el.com, netdev@...r.kernel.org, brouer@...hat.com Subject: Re: [net-next PATCH v5 5/6] virtio_net: add XDP_TX support On 16-12-08 01:18 PM, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 10:18:22AM -0800, John Fastabend wrote: >>> I guess this helps because it just slows down the guest. >>> I don't much like it ... >> >> I left it like this copying the pattern in balloon and input drivers. I >> can change it back to the previous pattern where it is only called if >> there is no errors. It has been running fine with the old pattern now >> for an hour or so. >> >> .John > > I'd prefer internal consistency. Could be a patch on top > if this helps. I'm happy it isn't actually buggy. > Let me know whether you want to post v6 or > want me to ack this one. > I think because DaveM has closed net-next ACK'ing this set would be great to get it in Dave's tree. Then I can post a small "fix" so that it is consistent between normal stack and xdp tx path after that. Thanks, John
Powered by blists - more mailing lists