netdev - Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a451128-7d3a-1204-c2e2-2a928b8638e9@mellanox.com>
Date:   Fri, 9 Dec 2016 01:16:22 +0200
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Arnd Bergmann <arnd@...db.de>, Matan Barak <matanb@...lanox.com>,
        "Leon Romanovsky" <leonro@...lanox.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Daniel Jurgens <danielj@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>, <netdev@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for
 dma_addr_t



On 12/08/2016 11:57 PM, Arnd Bergmann wrote:
> On 32-bit ARM with 64-bit dma_addr_t I get this warning about an
> incorrect format string:
> 
> In file included from /git/arm-soc/drivers/net/ethernet/mellanox/mlx5/core/alloc.c:42:0:
> drivers/net/ethernet/mellanox/mlx5/core/alloc.c: In function ‘mlx5_frag_buf_alloc_node’:
> drivers/net/ethernet/mellanox/mlx5/core/alloc.c:134:12: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 
> We have the special %pad format for printing dma_addr_t, so use that
> to print the correct address and avoid the warning.
> 
> Fixes: 1c1b522808a1 ("net/mlx5e: Implement Fragmented Work Queue (WQ)")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thank you Arnd !!

Acked-by: Saeed Mahameed <saeedm@...lanox.com>