netdev - Re: [PATCH] net:ethernet:samsung:initialize cur_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161209224203.GA8878@electric-eye.fr.zoreil.com>
Date:   Fri, 9 Dec 2016 23:42:03 +0100
From:   Francois Romieu <romieu@...zoreil.com>
To:     Rayagond Kokatanur <rayagond.kokatanur@...il.com>
Cc:     siva.kallam@...sung.com, bh74.an@...sung.com, ks.giri@...sung.com,
        vipul.pandya@...sung.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net:ethernet:samsung:initialize cur_rx_qnum

Rayagond Kokatanur <rayagond.kokatanur@...il.com> :
> This patch initialize the cur_rx_qnum upon occurence of rx interrupt,
> without this initialization driver will not work with multiple rx queues
> configurations.
> 
> NOTE: This patch is not tested on actual hw.

(your patch should include a Signed-off-by)

Imho the driver needs more changes to support multiple rx queues.

- rx interrupt for queue A -> priv->cur_rx_qnum = A
- rx interrupt for queue B -> priv->cur_rx_qnum = B
- rx napi processing       -> Err...

Please start turning priv->cur_rx_qnum into a SXGBE_RX_QUEUES sized bitmap.

-- 
Ueimor