netdev - Re: [PATCH net-next 3/3] net: xgene: avoid bogus maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161208.213116.355037793343857244.davem@davemloft.net>
Date:   Thu, 08 Dec 2016 21:31:16 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     isubramanian@....com, kchudgar@....com, qnguyen@....com,
        kdinh@....com, toanle@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] net: xgene: avoid bogus
 maybe-uninitialized warning

From: Arnd Bergmann <arnd@...db.de>
Date: Thu,  8 Dec 2016 22:57:05 +0100

> In some configurations, gcc cannot trace the state of variables
> across a spin_unlock() barrier, leading to a warning about
> correct code:
> 
> xgene_enet_main.c: In function 'xgene_enet_start_xmit':
> ../../../phy/mdio-xgene.h:112:14: error: 'mss_index' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> Here we can trivially move the assignment before that spin_unlock,
> which reliably avoids the warning.
> 
> Fixes: e3978673f514 ("drivers: net: xgene: Fix MSS programming")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.