netdev - Re: [PATCH net-next v6 0/2] net/sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2016 07:44:02 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     David Miller <davem@...emloft.net>,
        Or Gerlitz <gerlitz.or@...il.com>
Cc:     jiri@...lanox.com, tom@...bertland.com, netdev@...r.kernel.org,
        ogerlitz@...lanox.com
Subject: Re: [PATCH net-next v6 0/2] net/sched: cls_flower: Support matching
 on ICMP

Hi Dave, Hi Or,

On Thu, Dec 08, 2016 at 11:58:10AM -0500, David Miller wrote:
> From: Simon Horman <simon.horman@...ronome.com>
> Date: Wed,  7 Dec 2016 13:48:26 +0100
> 
> > this series adds support for matching on ICMP type and code to
> > cls_flower.
> 
> Series applied, thanks Simon.  I guess we'll see some netronome
> offloading of this stuff coming soon? :-)

That is the direction I would like to see this go in.

> Simon and Or, you both added extensions to cls_flower at the same
> time.  Or's changes went in first, so his UAPI numbers did not change.
> Simons, your changes went in next so your numbers did change and
> therefore you will have to recompile any userland components you were
> using for testing.
> 
> Just FYI...

On Thu, Dec 08, 2016 at 10:43:05PM +0200, Or Gerlitz wrote:
> On Thu, Dec 8, 2016 at 6:58 PM, David Miller <davem@...emloft.net> wrote:
> 
> > Simon and Or, you both added extensions to cls_flower at the same
> > time.  Or's changes went in first, so his UAPI numbers did not change.
> > Simons, your changes went in next so your numbers did change and
> > therefore you will have to recompile any userland components you were
> > using for testing.
> 
> Yeah, I guess you had to do some rebasing there for Simon's series...
> thanks for taking care

Likewise, thanks a lot for handling the conflict.