netdev - Re: [PATCH] net: smsc911x: back out silently on probe deferrals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161209.230547.1113699691008813275.davem@davemloft.net>
Date:   Fri, 09 Dec 2016 23:05:47 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     linus.walleij@...aro.org
Cc:     netdev@...r.kernel.org, steve.glendinning@...well.net,
        linux@...ck-us.net, jeremy.linton@....com,
        kamlakant.patel@...adcom.com, p.fedin@...sung.com
Subject: Re: [PATCH] net: smsc911x: back out silently on probe deferrals

From: Linus Walleij <linus.walleij@...aro.org>
Date: Fri,  9 Dec 2016 14:18:00 +0100

> When trying to get a regulator we may get deferred and we see
> this noise:
> 
> smsc911x 1b800000.ethernet-ebi2 (unnamed net_device) (uninitialized):
>    couldn't get regulators -517
> 
> Then the driver continues anyway. Which means that the regulator
> may not be properly retrieved and reference counted, and may be
> switched off in case noone else is using it.
> 
> Fix this by returning silently on deferred probe and let the
> system work it out.
> 
> Cc: Jeremy Linton <jeremy.linton@....com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Looks good, applied, thanks.