netdev - Re: [PATCH] i40e: don't truncate match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161209.230740.2078488933726675303.davem@davemloft.net>
Date:   Fri, 09 Dec 2016 23:07:40 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jacob.e.keller@...el.com
Cc:     intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com,
        netdev@...r.kernel.org, sfr@...b.auug.org.au,
        bimmy.pujari@...el.com
Subject: Re: [PATCH] i40e: don't truncate match_method assignment

From: Jacob Keller <jacob.e.keller@...el.com>
Date: Fri,  9 Dec 2016 13:39:21 -0800

> The .match_method field is a u8, so we shouldn't be casting to a u16,
> and because it is only one byte, we do not need to byte swap anything.
> Just assign the value directly. This avoids issues on Big Endian
> architectures which would have byte swapped and then incorrectly
> truncated the value.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Bimmy Pujari <bimmy.pujari@...el.com>
> ---
> Not sure if this was already in Jeff's queue, but since it's an obvious
> fix for the issue found by Stephen, I thought I'd send it out now just
> to make sure. Thanks for catching this, and sorry we didn't find the fix
> earlier.

Jeff, what do you want me to do with this?