netdev - Re: [iproute2 net-next 2/8] bpf: export bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <584C72A5.9020801@iogearbox.net>
Date:   Sat, 10 Dec 2016 22:24:53 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     David Ahern <dsa@...ulusnetworks.com>, netdev@...r.kernel.org,
        stephen@...workplumber.org
Subject: Re: [iproute2 net-next 2/8] bpf: export bpf_prog_load

On 12/10/2016 09:32 PM, David Ahern wrote:
> Code move only; no functional change intended.
>
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> ---
>   include/bpf_util.h |  3 +++
>   lib/bpf.c          | 40 ++++++++++++++++++++--------------------
>   2 files changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/include/bpf_util.h b/include/bpf_util.h
> index 49b96bbc208f..dcbdca6978d6 100644
> --- a/include/bpf_util.h
> +++ b/include/bpf_util.h
> @@ -75,6 +75,9 @@ int bpf_trace_pipe(void);
>
>   void bpf_print_ops(FILE *f, struct rtattr *bpf_ops, __u16 len);
>
> +int bpf_prog_load(enum bpf_prog_type type, const struct bpf_insn *insns,
> +		  size_t size_insns, const char *license, char *log,
> +		  size_t size_log);

Just a really minor nit: please add a newline here.

>   int bpf_prog_attach(int prog_fd, int target_fd, enum bpf_attach_type type);
>   int bpf_prog_detach(int target_fd, enum bpf_attach_type type);
>