[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Dec 2016 12:11:07 -0500
From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To: Florian Fainelli <f.fainelli@...il.com>,
Volodymyr Bendiuga <valdr.linuxnext@...il.com>
Cc: Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>, andrew@...n.ch,
netdev@...r.kernel.org,
Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
Subject: Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries
Hi all,
Florian Fainelli <f.fainelli@...il.com> writes:
> Seeing such a change makes me wonder if we should not try to push some
> of this hashtable abstraction (provided that we agree we want it) at a
> higher layer, like net/dsa/slave.c?
That is the major reason why I am reluctant to cache stuffs in drivers.
In most cases, we want the DSA drivers to be "stupid", as much stateless
as possible, simply implementing the supported DSA switch operations.
The DSA core then handles the generic logic of how switch fabrics should
behave, and thus all DSA drivers are consistent and benefit from this.
Thanks,
Vivien
Powered by blists - more mailing lists